Commit Graph

11698 Commits

Author SHA1 Message Date
wn_
21aebd8ff1 Use FeedEnclosure throughout RSSUtils. 2024-01-20 17:37:10 +00:00
Andrew Dolgov
a86df7eac8 Merge branch 'bugfix/web-nginx-healthcheck' into 'master'
Use APP_BASE in the web-nginx health check URL.

See merge request tt-rss/tt-rss!21
2024-01-19 20:13:00 +00:00
wn_
03c9d4f390 Use APP_BASE in the web-nginx health check URL. 2024-01-19 16:19:07 +00:00
Andrew Dolgov
283ad4ebea Merge branch 'feature/unused-var-cleanup' into 'master'
Clean up some unused variables.

See merge request tt-rss/tt-rss!19
2024-01-13 18:29:30 +00:00
Andrew Dolgov
d334023267 Merge branch 'feature/reduce-fetch-error-message' into 'master'
Only include the exception message in 'UrlHelper::$fetch_last_error'.

See merge request tt-rss/tt-rss!20
2024-01-13 18:27:19 +00:00
wn_
8ef2803b27 Only include the exception message in 'UrlHelper::$fetch_last_error'.
Before this the stack trace was included, which is a bit much.
2024-01-09 12:38:32 +00:00
Andrew Dolgov
de214a01d2 shorten DIGEST_MIN_SCORE help text 2024-01-09 12:38:25 +03:00
Andrew Dolgov
bcdfedeb8a * mark get_pref/set_pref wrappers as deprecated
* add per-user preference for minimal score required for digest
2024-01-09 11:45:40 +03:00
Andrew Dolgov
ea6cdcccb0 * mail test - fill user email address as default
* digest - fix some warnings
2024-01-09 11:28:32 +03:00
wn_
8727fb3ba8 Clean up some unused variables.
This is essentially 1ccc0c8c1a without the renames and some other things related to Psalm.
2024-01-08 22:46:13 +00:00
Andrew Dolgov
f0f22c23c5 Merge branch 'feature/urlhelper-fetch-do-assoc-opts' into 'master'
Update all UrlHelper::fetch() calls to use the associative array approach.

See merge request tt-rss/tt-rss!18
2023-12-31 09:08:03 +00:00
wn_
90e7bf7cc3 Update all UrlHelper::fetch() calls to use the associative array approach.
The other approach (passing in individual params) was marked as deprecated a few years ago.
2023-12-30 15:39:17 +00:00
Andrew Dolgov
a882eb13f7 Merge branch 'feature/early-fail-disallowed-redirects' into 'master'
Perform validation of redirect URLs during the redirect process.

See merge request tt-rss/tt-rss!17
2023-12-29 04:38:59 +00:00
wn_
91a91dac15 Perform validation of redirect URLs during the redirect process.
Previously, validation was only done after all redirects and the final request had completed.  This approach ensures all redirects are to URLs that pass extended validation.
2023-12-29 00:41:52 +00:00
Andrew Dolgov
51cd02fc3e Merge branch 'feature/use-guzzle' into 'master'
Use Guzzle

See merge request tt-rss/tt-rss!16
2023-12-24 16:14:45 +00:00
wn_
0ea9db3170 Fix specifying auth type in UrlHelper::fetch(), add a test for 403 auth retry. 2023-12-24 11:21:43 +00:00
wn_
9a1f7c2ebf Appease PHPStan in UrlHelperTest 2023-12-23 19:58:39 +00:00
wn_
3c171cc92c Add some tests for UrlHelper::fetch() 2023-12-23 19:52:56 +00:00
wn_
e33b0297d5 Ensure the feed name is easily visible when looking at the feeds with errors list. 2023-12-23 17:01:24 +00:00
wn_
9132360d46 Rework content encoding error retrying in UrlHelper::fetch() 2023-12-23 16:34:39 +00:00
wn_
d82da74363 Clean up UrlHelper::resolve_redirects().
Also: this doesn't appear to be used... but maybe in some plugin?
2023-12-23 15:56:21 +00:00
wn_
ff59fbd460 Add back 'any auth' retry in UrlHelper::fetch() 2023-12-23 15:34:21 +00:00
wn_
e85d47dfd4 Use Guzzle 2023-12-22 16:51:23 +00:00
Andrew Dolgov
d4ae6c67db Merge branch 'dont-sanitize-figure-tag' into 'master'
sanitizer: keep <figure> intact

See merge request tt-rss/tt-rss!15
2023-12-18 14:51:58 +00:00
Chih-Hsuan Yen
f1a9ac9b15 sanitizer: add a test to make sure <figure> is intact
Somehow with the old approach, `<figure>` is rearranged into `<head>`,
and the latter is stripped by `Sanitizer::strip_harmful_tags()` (see
[1]). The issue is fixed by [2]. Here I added a test for the regression.

[1] https://community.tt-rss.org/t/unexpected-behavior-with-figure-tag/6244
[2] 67012f9dac
2023-12-18 22:46:35 +08:00
Andrew Dolgov
67012f9dac Revert "Fix sanitizer with libxml2 >= 2.12.0"
This reverts commit d4da4dcc32.
2023-12-17 22:42:52 +03:00
Andrew Dolgov
14ad8b21d5 bump CI jobs & utility scripts to php83 2023-12-10 09:36:09 +03:00
Andrew Dolgov
4b3cf17d8d Merge branch 'master' of gitlab.tt-rss.org:tt-rss/tt-rss 2023-12-10 09:32:00 +03:00
Andrew Dolgov
1b31e6fd5b Merge branch 'feature/php-8.3' into 'master'
Bump to Alpine 3.19 and PHP 8.3.

See merge request tt-rss/tt-rss!14
2023-12-10 06:18:10 +00:00
wn_
7883f024e7 Bump to Alpine 3.19 and PHP 8.3.
* https://alpinelinux.org/posts/Alpine-3.19.0-released.html
* https://www.php.net/releases/8.3/en.php
2023-12-07 12:38:23 +00:00
Andrew Dolgov
8f66f579e4 add coverage-filter 2023-12-02 18:04:55 +03:00
Andrew Dolgov
09898ccbc8 add phpunit code coverage driver 2023-12-02 18:03:06 +03:00
Andrew Dolgov
2b8e344532 add some unittest options for xmlrunner 2023-12-02 12:48:54 +03:00
Andrew Dolgov
e453befab6 fix filename 2023-12-02 12:47:36 +03:00
Andrew Dolgov
dbb6e7291e enable unit test results for selenium 2023-12-02 12:44:21 +03:00
Andrew Dolgov
eac9e7c103 collect phpunit artifacts 2023-12-02 11:42:12 +03:00
Andrew Dolgov
93bd96e356 add env prefixes 2023-12-02 11:38:25 +03:00
Andrew Dolgov
7005d6d5f3 add db vars 2023-12-02 11:36:09 +03:00
Andrew Dolgov
0621d22bbe add cobertura args for phpunit-integration 2023-12-02 11:30:17 +03:00
Andrew Dolgov
cc133d2c0a disable local rules for integration tests 2023-12-02 11:16:52 +03:00
Andrew Dolgov
e52eaf0e7b add sanitizer integration test 2023-12-02 11:14:07 +03:00
Andrew Dolgov
ce9847d317 Merge branch 'fix-sanitizer-new-libxml2' into 'master'
Fix sanitizer with libxml2 >= 2.12.0

See merge request tt-rss/tt-rss!12
2023-12-01 12:26:41 +00:00
Chih-Hsuan Yen
d4da4dcc32 Fix sanitizer with libxml2 >= 2.12.0
Somehow with newer libxml2, `<?xml encoding="UTF-8">` no longer enforces
UTF-8. Instead, non-ASCII contents are treated as ISO-8859-1 and get
broken.

For example, `<p>中文</p>` becomes
`<p>&auml;&cedil;&shy;&aelig;&#150;&#135;</p>` (should be
`<p>&#20013;&#25991;</p>`).

Switching to another trick mentioned on [1] fixes the issue, and the
new trick still works with older libxml2 (tested 2.11.5).

As a side note, DOMDocument::loadHTML uses HTMLParser in libxml2 [2][3].

[1] https://stackoverflow.com/questions/8218230/php-domdocument-loadhtml-not-encoding-utf-8-correctly
[2] https://github.com/php/php-src/blob/php-8.1.26/ext/dom/document.c#L1855
[3] https://gnome.pages.gitlab.gnome.org/libxml2/devhelp/libxml2-HTMLparser.html
2023-11-26 21:04:56 +08:00
Andrew Dolgov
2c7e000120 set registry project 2023-11-25 20:21:10 +03:00
Andrew Dolgov
1fe1132a1a use variable for fastcgi_pass to force resolver usage 2023-11-07 09:56:23 +03:00
Andrew Dolgov
61910acbcd explicitly set resolver in the nginx container (configurable envvar) 2023-11-07 08:38:11 +03:00
Andrew Dolgov
ff4248b09e add wip UI/backend stuff to filter feed tree 2023-11-03 08:33:35 +03:00
Andrew Dolgov
0b7d021f8e add wait-for-element to selenium test 2023-11-01 13:40:35 +03:00
Andrew Dolgov
d4c972f551 remove .git before_scripts 2023-11-01 13:24:32 +03:00
Andrew Dolgov
f48f1b0131 Revert "pass .git to docker context so self-built images would have some way to determine version without CI variables"
This reverts commit 5cfde4cada.
2023-11-01 13:24:04 +03:00