938f7db482
correctly show non-docker git installs as unsupported
Andrew Dolgov
2021-11-17 10:36:04 +03:00
5980b3d2cb
pluginhost: set stricter @params
Andrew Dolgov
2021-11-16 18:35:13 +03:00
10d1a8c05a
adjust phpdoc tags for hook definitions/constants (make them reference each other)
Andrew Dolgov
2021-11-16 16:31:40 +03:00
ad30d39e2a
not dead: Article.assigntolabel etc are exported methods called by frontend (Headlines.js)
Andrew Dolgov
2021-11-16 15:45:35 +03:00
4166628c36
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
Andrew Dolgov
2021-11-16 09:19:19 +03:00
6a8030fd76
mailer: don't crash if php mail() fails with no reported errors
Andrew Dolgov
2021-11-16 09:19:12 +03:00
d78ba7b3a9
Minor fix in 'classes/articles.php'.
wn_
2021-11-16 02:14:31 +00:00
b2952843f5
* DiskCache: add download() helper * Af_Comics_Gocomics_FarSide: cache linked images because it seems to be required anyway
Andrew Dolgov
2021-11-15 23:22:21 +03:00
3a3fde1a2e
when uninstall plugins, refresh plugins index instead of reloading entire prefs pane
Andrew Dolgov
2021-11-15 20:18:37 +03:00
8cd69fe15c
when uninstall plugins, refresh plugins index instead of reloading entire prefs pane
Andrew Dolgov
2021-11-15 20:18:37 +03:00
ef1e2a8b2f
update dojo/dijit to 1.16.4
Andrew Dolgov
2021-11-15 18:48:47 +03:00
1db1be7a81
update phpstan to 1.1.2 (composer files)
Andrew Dolgov
2021-11-15 18:44:24 +03:00
4c37fa4b41
update phpstan to 1.1.2; update php-qrcode to 3.4.1
Andrew Dolgov
2021-11-15 18:33:35 +03:00
109b702ed0
Minor fix to DOMNodeList#item() potential type (null vs false)
wn_
2021-11-15 12:24:38 +00:00
85b974af32
auth_internal: limit password throttling to failed login attempts not using OTP
Andrew Dolgov
2021-11-15 13:16:49 +03:00
26f47c0694
remove themes/Makefile (obsolete, replaced with gulp)
Andrew Dolgov
2021-11-15 08:27:49 +03:00
aa924d9ee7
deal with several DOMElement-related errors
Andrew Dolgov
2021-11-15 08:26:02 +03:00
a92070da06
unignore several phpstan errors
Andrew Dolgov
2021-11-15 08:20:56 +03:00
2493c9cddd
set better matching type hint on virtual feed object
Andrew Dolgov
2021-11-15 08:19:44 +03:00
676c5787e7
require virtual feed plugins to implement IVirtualFeed
Andrew Dolgov
2021-11-15 07:11:29 +03:00
8dfefe7968
add IVirtualFeed interface for plugins implementing virtual feeds
Andrew Dolgov
2021-11-15 07:08:41 +03:00
3bd13b91c8
add IVirtualFeed interface for plugins implementing virtual feeds
Andrew Dolgov
2021-11-15 07:08:41 +03:00
07ea364189
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
Andrew Dolgov
2021-11-15 06:54:04 +03:00
edc7998851
revise phpdoc annotations for hook_search()
Andrew Dolgov
2021-11-15 06:53:55 +03:00
fb208bb136
Fix a PHPStan warning in 'UrlHelper::rewrite_relative()'.
wn_
2021-11-15 03:28:17 +00:00
41b4eef504
Address PHPStan warnings for FeedEnclosure.
wn_
2021-11-15 02:46:19 +00:00
8943604aad
Change the param type for UserHelper::hash_password() $algo to appease PHPStan.
wn_
2021-11-14 22:44:48 +00:00
324d926eb4
Also fix the param signature for Plugin#hook_hotkey_info()
wn_
2021-11-14 22:16:16 +00:00
12f9df1066
Fix the return signature for Plugin#hook_hotkey_info()
wn_
2021-11-14 22:11:27 +00:00
8f749fe61b
Address PHPStan warnings in 'include/colors.php'.
wn_
2021-11-14 21:06:06 +00:00
6d438c5a77
Address PHPStan warning in 'classes/pref/users.php'.
wn_
2021-11-14 20:27:17 +00:00
5632d75a45
Address PHPStan warning in 'classes/pref/system.php'.
wn_
2021-11-14 20:26:21 +00:00
abab2a94e8
Address PHPStan warning in 'classes/pref/prefs.php'.
wn_
2021-11-14 20:12:37 +00:00
b8f0627a0e
Address PHPStan warning in 'classes/pref/labels.php'.
wn_
2021-11-14 20:03:57 +00:00
56cf425e45
revise prototype for hook_enclosure_imported
Andrew Dolgov
2021-11-14 23:03:25 +03:00
c3fbf56984
deal with most of warnings in plugins/af_readability
Andrew Dolgov
2021-11-14 21:25:56 +03:00
242cf916ef
deal with phpstan warnings in plugins/note, nsfw, and share
Andrew Dolgov
2021-11-14 21:20:59 +03:00
5f808051b2
deal with phpstan warnings in auto_assign_labels and bookmarklets
Andrew Dolgov
2021-11-14 21:14:21 +03:00
f537502fce
deal with (most of) phpstan warnings in auth_internal and auth_remote
Andrew Dolgov
2021-11-14 21:09:53 +03:00
67a89e861d
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
Andrew Dolgov
2021-11-14 21:01:25 +03:00
9326ed605f
Address PHPStan warning in 'classes/pref/filters.php'.
wn_
2021-11-14 17:59:02 +00:00
812f5f532e
Address PHPStan warning in 'classes/mailer.php'.
wn_
2021-11-14 17:57:17 +00:00
91c9a73532
deal with phpstan warnings in plugins/cache_starred_images.php
Andrew Dolgov
2021-11-14 20:59:49 +03:00
931a7533ce
adjust some return types in urlhelper
Andrew Dolgov
2021-11-14 20:53:30 +03:00
80291ffe0c
deal with phpstan warnings in plugins/af_redditimgur.php
Andrew Dolgov
2021-11-14 20:51:22 +03:00
cfc31fc692
set annotations/types in af_psql_trgm
Andrew Dolgov
2021-11-14 20:36:55 +03:00
d17b79311e
set missing annotations in af_comics
Andrew Dolgov
2021-11-14 20:33:37 +03:00
afdb4b0072
set phpdoc annotations for auth_base
Andrew Dolgov
2021-11-14 20:26:05 +03:00
6bd6a14c20
revise phpdoc annotations for hook_sanitize()
Andrew Dolgov
2021-11-14 20:19:12 +03:00
f5c881586b
Handle potentially null link, title, etc. in FeedParser.
wn_
2021-11-14 16:59:21 +00:00
7988c79bd4
plugin.php: add some minor method phpdoc corrections
Andrew Dolgov
2021-11-14 18:05:31 +03:00
1b5c61ac85
userhelper: add a phpdoc variable class hint
Andrew Dolgov
2021-11-14 18:02:20 +03:00
01b39d985c
deal with the rest of warnings in plugin.php
Andrew Dolgov
2021-11-14 18:00:03 +03:00
dd7299b6d0
deal with a few more phpstan warnings re: base plugin class
Andrew Dolgov
2021-11-14 17:19:35 +03:00
55729b4bbd
fix HOOK_QUERY_HEADLINES being invoked with different argument lists, add some more phpdoc comments for base plugin class
Andrew Dolgov
2021-11-14 17:07:47 +03:00
af2f4460ce
* deal with some phpstan warnings in base plugin class * arguably better hack for incompatible plugins causing E_COMPILE_ERROR
Andrew Dolgov
2021-11-14 16:49:10 +03:00
c3ffa08807
deal with phpstan warnings in update.php
Andrew Dolgov
2021-11-14 16:15:31 +03:00
98af46addd
prefs: properly report failures when loading plugin list
Andrew Dolgov
2021-11-14 16:13:06 +03:00
cf93371607
show safe mode warning dialog in prefs
Andrew Dolgov
2021-11-14 16:12:27 +03:00
8b743f7249
xhr.json: properly pass failure callback to xhr.post()
Andrew Dolgov
2021-11-14 16:07:52 +03:00
d3d3bceec9
xhr.json: properly pass failure callback to xhr.post()
Andrew Dolgov
2021-11-14 16:07:52 +03:00
9b5d199ad9
xhr.json: don't call resolve() on failed to parse data
Andrew Dolgov
2021-11-14 15:57:43 +03:00
fe1feca009
xhr.json: don't call resolve() on failed to parse data
Andrew Dolgov
2021-11-14 15:57:43 +03:00
15af164f69
pluginhost: add a hack to not crash on an incompatible plugin more than once (per login) - UGLY
Andrew Dolgov
2021-11-14 11:50:55 +03:00
0a2dcacbcf
normalize some mismatching hook function definitions to match base Plugin class
Andrew Dolgov
2021-11-14 11:11:49 +03:00
81a10f69bc
deal with phpstan warnings related to base authentication modules
Andrew Dolgov
2021-11-14 10:48:32 +03:00
5a50c333b2
Address PHPStan warnings in 'classes/pref/filters.php'.
wn_
2021-11-13 16:21:58 +00:00
fe5ada7250
set some annotations on Plugin hook methods
Andrew Dolgov
2021-11-13 20:07:13 +03:00
5e34fe17a7
experimental: bring back plugin hooks to Plugin base class once (to be improved/fixed with annotations later)
Andrew Dolgov
2021-11-13 20:03:28 +03:00
618e96b793
deal with some warnings in plugins/trgm,readability and base plugin class
Andrew Dolgov
2021-11-13 19:55:30 +03:00
03d0692268
no need to duplicate annotations
Andrew Dolgov
2021-11-13 19:52:47 +03:00
68d7cf44f9
phpstan: deal with plugins/share
Andrew Dolgov
2021-11-13 19:49:37 +03:00
37827427a2
rework previous Plugin changes as phpdoc annotations
Andrew Dolgov
2021-11-13 19:41:50 +03:00
9845d5fd15
revert all plugin base class related changes to keep compatibility with extant plugins (for the time being)
Andrew Dolgov
2021-11-13 19:36:24 +03:00
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
wn_
2021-11-13 16:00:56 +00:00
a18473e4c0
Address PHPStan warnings in 'classes/pref/feeds.php'.
wn_
2021-11-13 15:50:37 +00:00
b37a03fb31
Fix the type of Labels::update_cache()
wn_
2021-11-13 14:41:22 +00:00
f2323bda81
fix phpstan warnings in classes/plugin-template.php
Andrew Dolgov
2021-11-13 18:26:11 +03:00
70051742af
experimental: also don't keep base plugin template as a non-analyzed file
Andrew Dolgov
2021-11-13 18:21:04 +03:00
b381e95792
experimental: auto-generate and add all plugin hook methods to Plugin class
Andrew Dolgov
2021-11-13 18:18:05 +03:00
8a83f061bf
fix phpstan warnings in classes/sanitizer.php
Andrew Dolgov
2021-11-13 17:52:03 +03:00
a7983d475e
fix phpstan warnings in classes/api.php
Andrew Dolgov
2021-11-13 17:51:26 +03:00
77b8dc7386
fix phpstan warnings in classes/feedparser.php
Andrew Dolgov
2021-11-13 17:48:52 +03:00
45431170b6
fix phpstan warnings in classes/db/migrations.php
Andrew Dolgov
2021-11-13 17:31:13 +03:00
3ba8d964b6
Address PHPStan warnings in 'classes/api.php'.
wn_
2021-11-13 14:15:20 +00:00
1ec003ce35
Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag).
wn_
2021-11-13 14:05:43 +00:00
25775bb407
Fix type of 'check_first_id' in Feeds '_format_headlines_list'.
wn_
2021-11-13 04:14:18 +00:00
d3a81f598b
Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0
wn_
2021-11-12 21:17:31 +00:00
2c41bc7fbc
Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'.
wn_
2021-11-12 06:16:18 +00:00
9db5e402a0
Address PHPStan warnings in 'classes/rpc.php'.
wn_
2021-11-12 05:42:55 +00:00
011c941e7c
Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'.
wn_
2021-11-12 05:24:02 +00:00
b0eb347839
Fix a warning in 'classes/counters.php'.
wn_
2021-11-12 05:04:55 +00:00
f0ad5881c0
PHPStan warning fix in 'backend.php'.
wn_
2021-11-12 04:53:53 +00:00
734be4ebd1
Minor PHPStand warning fix in 'update.php'.
wn_
2021-11-12 04:51:35 +00:00
763515de79
Address PHPStan warnings in 'classes/feeds.php'.
wn_
2021-11-12 04:48:06 +00:00
5606e38bff
Update signature of handler 'csrf_ignore' to include types.
wn_
2021-11-12 02:01:31 +00:00
57bf56f794
Address PHPStan warnings in 'classes/article.php'.
wn_
2021-11-12 01:50:40 +00:00
a0f37c3206
Address PHPStan warnings in 'classes/pluginhost.php'.
wn_
2021-11-12 00:06:00 +00:00
95277fd099
Address PHPStan warnings in 'classes/labels.php'.
wn_
2021-11-11 22:28:13 +00:00