xle/tt-rss
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #432 from andersk/floating

Browse Source 
Make the floating title transition smoother
This commit is contained in:
Andrew Dolgov
2015-01-31 10:33:53 +03:00
parent 3192fb43bc 5c145bde7a
commit fbea9eaad2
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
index.php
View File

@@ -265,7 +265,7 @@
<div id="headlines-wrap-inner" dojoType="dijit.layout.BorderContainer" region="center"> <div id="headlines-wrap-inner" dojoType="dijit.layout.BorderContainer" region="center">
<div id="floatingTitle" style="display : none"></div> <div id="floatingTitle" style="visibility : hidden"></div>
<div id="headlines-frame" dojoType="dijit.layout.ContentPane" <div id="headlines-frame" dojoType="dijit.layout.ContentPane"
onscroll="headlines_scroll_handler(this)" region="center"> onscroll="headlines_scroll_handler(this)" region="center">

15
js/viewfeed.js
View File

@@ -56,7 +56,7 @@ function headlines_callback2(transport, offset, background, infscroll_req) {
if (infscroll_req == false) { if (infscroll_req == false) {
$("headlines-frame").scrollTop = 0; $("headlines-frame").scrollTop = 0;
Element.hide("floatingTitle"); $("floatingTitle").style.visibility = "hidden";
$("floatingTitle").setAttribute("rowid", 0); $("floatingTitle").setAttribute("rowid", 0);
$("floatingTitle").innerHTML = ""; $("floatingTitle").innerHTML = "";
} }
@@ -1532,7 +1532,7 @@ function cdmCollapseArticle(event, id, unmark) {
if (row.offsetTop < $("headlines-frame").scrollTop) if (row.offsetTop < $("headlines-frame").scrollTop)
scrollToRowId(row.id); scrollToRowId(row.id);
Element.hide("floatingTitle"); $("floatingTitle").style.visibility = "hidden";
$("floatingTitle").setAttribute("rowid", false); $("floatingTitle").setAttribute("rowid", false);
} }
@@ -2357,7 +2357,7 @@ function scrollToRowId(id) {
var row = $(id); var row = $(id);
if (row) if (row)
$("headlines-frame").scrollTop = row.offsetTop; $("headlines-frame").scrollTop = row.offsetTop - 4;
} catch (e) { } catch (e) {
exception_error("scrollToRowId", e); exception_error("scrollToRowId", e);
@@ -2402,11 +2402,12 @@ function updateFloatingTitle(unread_only) {
PluginHost.run(PluginHost.HOOK_FLOATING_TITLE, child); PluginHost.run(PluginHost.HOOK_FLOATING_TITLE, child);
} }
if (child.offsetTop < hf.scrollTop - header.offsetHeight && $("floatingTitle").style.marginRight = hf.offsetWidth - child.offsetWidth + "px";
child.offsetTop + child.offsetHeight - hf.scrollTop > header.offsetHeight) if (header.offsetTop + header.offsetHeight < hf.scrollTop + $("floatingTitle").offsetHeight - 5 &&
Element.show("floatingTitle"); child.offsetTop + child.offsetHeight >= hf.scrollTop + $("floatingTitle").offsetHeight - 5)
$("floatingTitle").style.visibility = "visible";
else else
Element.hide("floatingTitle"); $("floatingTitle").style.visibility = "hidden";
return; return;