simplify default global config, expand sanity_check messages

This commit is contained in:
Andrew Dolgov
2011-12-13 19:20:26 +04:00
parent a3b5394aaf
commit 09e8bdfd18
12 changed files with 283 additions and 311 deletions

View File

@@ -2,174 +2,134 @@
require_once "functions.php";
if (!file_exists("config.php")) {
print "<b>Fatal Error</b>: You forgot to copy
<b>config.php-dist</b> to <b>config.php</b> and edit it.\n";
exit;
}
$err_msg = "Configuration file not found. Looks like you forgot to copy config.php-dist to config.php and edit it.";
} else {
define('EXPECTED_CONFIG_VERSION', 23);
define('SCHEMA_VERSION', 86);
define('EXPECTED_CONFIG_VERSION', 24);
define('SCHEMA_VERSION', 86);
require_once "config.php";
require_once "sanity_config.php";
require_once "config.php";
require_once "sanity_config.php";
if (CONFIG_VERSION != EXPECTED_CONFIG_VERSION) {
$err_msg = "config: your config file version is incorrect. See config.php-dist.\n";
}
$purifier_cache_dir = CACHE_DIR . "/htmlpurifier";
if (!is_writable($purifier_cache_dir)) {
$err_msg = "config: HTMLPurifier cache directory should be writable by anyone (chmod -R 777 $purifier_cache_dir)";
}
if (GENERATED_CONFIG_CHECK != EXPECTED_CONFIG_VERSION) {
$err_msg = "config: your sanity_config.php is outdated, please recreate it using ./utils/regen_config_checks.sh";
}
foreach ($requred_defines as $d) {
if (!defined($d)) {
$err_msg = "config: required constant $d is not defined. Please check config.php";
if (CONFIG_VERSION != EXPECTED_CONFIG_VERSION) {
$err_msg = "Configuration file (config.php) has incorrect version. Update it with new options from config.php-dist and set CONFIG_VERSION to the correct value.";
}
}
if (defined('RSS_BACKEND_TYPE')) {
print "<b>Fatal error</b>: RSS_BACKEND_TYPE is deprecated. Please remove this
option from config.php\n";
exit;
}
$purifier_cache_dir = CACHE_DIR . "/htmlpurifier";
if (file_exists("xml-export.php") || file_exists("xml-import.php")) {
print "<b>Fatal Error</b>: XML Import/Export tools (<b>xml-export.php</b>
and <b>xml-import.php</b>) could be used maliciously. Please remove them
from your TT-RSS instance.\n";
exit;
}
if (!is_writable($purifier_cache_dir)) {
$err_msg = "HTMLPurifier cache directory should be writable by anyone (chmod -R 777 $purifier_cache_dir)";
}
if (SINGLE_USER_MODE && DAEMON_UPDATE_LOGIN_LIMIT > 0) {
print "<b>Fatal Error</b>: Please set DAEMON_UPDATE_LOGIN_LIMIT
to 0 in single user mode.\n";
exit;
}
if (GENERATED_CONFIG_CHECK != EXPECTED_CONFIG_VERSION) {
$err_msg = "Configuration option checker sanity_config.php is outdated, please recreate it using ./utils/regen_config_checks.sh";
}
if (!defined('SESSION_EXPIRE_TIME')) {
$err_msg = "config: SESSION_EXPIRE_TIME is undefined";
}
if (SESSION_EXPIRE_TIME < 60) {
$err_msg = "config: SESSION_EXPIRE_TIME is too low (less than 60)";
}
if (SESSION_EXPIRE_TIME < SESSION_COOKIE_LIFETIME) {
$err_msg = "config: SESSION_EXPIRE_TIME should be greater or equal to" .
"SESSION_COOKIE_LIFETIME";
}
/* if (defined('DISABLE_SESSIONS')) {
$err_msg = "config: you have enabled DISABLE_SESSIONS. Please disable this option.";
} */
if (DATABASE_BACKED_SESSIONS && SINGLE_USER_MODE) {
$err_msg = "config: DATABASE_BACKED_SESSIONS is incompatible with SINGLE_USER_MODE";
}
if (DATABASE_BACKED_SESSIONS && DB_TYPE == "mysql") {
$err_msg = "config: DATABASE_BACKED_SESSIONS are currently broken with MySQL";
}
if (SINGLE_USER_MODE) {
$link = db_connect(DB_HOST, DB_USER, DB_PASS, DB_NAME);
if ($link) {
$result = db_query($link, "SELECT id FROM ttrss_users WHERE id = 1");
if (db_num_rows($result) != 1) {
$err_msg = "config: SINGLE_USER_MODE is enabled but default admin account (UID=1) is not found.";
foreach ($requred_defines as $d) {
if (!defined($d)) {
$err_msg = "Required configuration file parameter $d is not defined in config.php. You might need to copy it from config.php-dist.";
}
}
if (SESSION_EXPIRE_TIME < 60) {
$err_msg = "SESSION_EXPIRE_TIME set in config.php is too low, please set it to an integer value >= 60";
}
if (SESSION_EXPIRE_TIME < SESSION_COOKIE_LIFETIME) {
$err_msg = "SESSION_EXPIRE_TIME set in config.php should be >= to SESSION_COOKIE_LIFETIME";
}
if (SINGLE_USER_MODE) {
$link = db_connect(DB_HOST, DB_USER, DB_PASS, DB_NAME);
if ($link) {
$result = db_query($link, "SELECT id FROM ttrss_users WHERE id = 1");
if (db_num_rows($result) != 1) {
$err_msg = "SINGLE_USER_MODE is enabled in config.php but default admin account is not found.";
}
}
}
if (SELF_URL_PATH == "http://yourserver/tt-rss/") {
if ($_SERVER['HTTP_REFERER']) {
$err_msg = "Please set SELF_URL_PATH to the correct value for your server (possible value: <b>" . $_SERVER['HTTP_REFERER'] . "</b>)";
} else {
$err_msg = "Please set SELF_URL_PATH to the correct value for your server.";
}
}
if (!is_writable(ICONS_DIR)) {
$err_msg = "ICONS_DIR defined in config.php is not writable (chmod -R 777 ".ICONS_DIR.").\n";
}
if (ini_get("open_basedir")) {
$err_msg = "PHP configuration option open_basedir is not supported. Please disable this in PHP settings file (php.ini).";
}
if (!function_exists("curl_init") && !ini_get("allow_url_fopen")) {
$err_msg = "PHP configuration option allow_url_fopen is disabled, and CURL functions are not present. Either enable allow_url_fopen or install PHP extension for CURL.";
}
if (!function_exists("json_encode")) {
$err_msg = "PHP support for JSON is required, but was not found.";
}
if (DB_TYPE == "mysql" && !function_exists("mysql_connect")) {
$err_msg = "PHP support for MySQL is required for configured DB_TYPE in config.php.";
}
if (DB_TYPE == "pgsql" && !function_exists("pg_connect")) {
$err_msg = "PHP support for PostgreSQL is required for configured DB_TYPE in config.php";
}
if (!function_exists("mb_strlen")) {
$err_msg = "PHP support for mbstring functions is required, but was not found.";
}
if (!function_exists("ctype_lower")) {
$err_msg = "PHP support for ctype functions are required by HTMLPurifier.";
}
if (ini_get("safe_mode")) {
$err_msg = "PHP safe mode setting is not supported.";
}
if ((PUBSUBHUBBUB_HUB || PUBSUBHUBBUB_ENABLED) && !function_exists("curl_init")) {
$err_msg = "PHP support for CURL is required for PubSubHubbub.";
}
if (!class_exists("DOMDocument")) {
$err_msg = "PHP support for DOMDocument is required, but was not found.";
}
}
if (defined('MAIL_FROM')) {
$err_msg = "config: MAIL_FROM has been split into DIGEST_FROM_NAME and DIGEST_FROM_ADDRESS";
}
if ($err_msg) { ?>
<html>
<head>
<title>Fatal error</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<link rel="stylesheet" type="text/css" href="utility.css">
</head>
if (!defined('COUNTERS_MAX_AGE')) {
$err_msg = "config: option COUNTERS_MAX_AGE expected, but not defined";
}
<div class="floatingLogo"><img src="images/logo_wide.png"></div>
if (defined('DAEMON_REFRESH_ONLY')) {
$err_msg = "config: option DAEMON_REFRESH_ONLY is obsolete. Please remove this option and read about other ways to update feeds on the <a href='http://tt-rss.org/wiki/UpdatingFeeds'>wiki</a>.";
<h1>Fatal error</h1>
}
<p>Tiny Tiny RSS was unable to initialize properly. This usually means a misconfiguration or an incomplete upgrade. Please fix
the error indicated by the following message:</p>
if (defined('ENABLE_SIMPLEPIE')) {
$err_msg = "config: ENABLE_SIMPLEPIE is obsolete and replaced with DEFAULT_UPDATE_METHOD. Please adjust your config.php.";
}
<p>You might want to check tt-rss <a href="http://tt-rss.org/wiki">wiki</a> or the
<a href="http://tt-rss.org/forum">forums</a> for more information. Please search the forums before creating new topic
for your question.</p>
if (!defined('DEFAULT_UPDATE_METHOD') || (DEFAULT_UPDATE_METHOD != 0 &&
DEFAULT_UPDATE_METHOD != 1)) {
$err_msg = "config: DEFAULT_UPDATE_METHOD should be either 0 or 1.";
}
<body>
<?php echo format_error($err_msg) ?>
</body>
</html>
if (SELF_URL_PATH == "http://yourserver/tt-rss/") {
$err_msg = "config: please set SELF_URL_PATH to the correct value.";
}
if (!is_writable(ICONS_DIR)) {
$err_msg = "config: your ICONS_DIR (" . ICONS_DIR . ") is not writable.\n";
}
if (ini_get("open_basedir")) {
$err_msg = "php.ini: open_basedir is not supported.";
}
if (!function_exists("curl_init") && !ini_get("allow_url_fopen")) {
$err_msg = "php.ini: either allow_url_fopen or CURL needs to be enabled.";
}
if (!function_exists("json_encode")) {
$err_msg = "PHP: json functions not found.";
}
if (DB_TYPE == "mysql" && !function_exists("mysql_connect")) {
$err_msg = "PHP: MySQL functions not found.";
}
if (DB_TYPE == "pgsql" && !function_exists("pg_connect")) {
$err_msg = "PHP: PostgreSQL functions not found.";
}
if (!function_exists("mb_strlen")) {
$err_msg = "PHP: mbstring functions not found.";
}
if (!function_exists("ctype_lower")) {
$err_msg = "PHP: ctype functions not found (required for HTMLPurifier).";
}
if (ini_get("safe_mode")) {
$err_msg = "php.ini: Safe mode is not supported. If you wish to continue, remove this test from sanity_check.php and proceeed at your own risk. Please note that your bug reports will not be accepted or reviewed.";
}
if ((PUBSUBHUBBUB_HUB || PUBSUBHUBBUB_ENABLED) && !function_exists("curl_init")) {
$err_msg = "CURL is required for PubSubHubbub support.";
}
if (!class_exists("DOMDocument")) {
$err_msg = "PHP: DOMDocument extension not found.";
}
if (SELF_URL_PATH == "http://local.host/tt-rss") {
$err_msg = "config: please set SELF_URL_PATH to the correct value";
}
if (!ISCONFIGURED) {
$err_msg = "config: please read config.php completely.";
}
if ($err_msg) {
print "<b>Fatal Error</b>: $err_msg\n";
exit;
<?php
die;
}
?>