From 51c9fe883978ead8e0eb013ef8c770cad2f4ccad Mon Sep 17 00:00:00 2001 From: Philip Sargent Date: Mon, 28 Jul 2025 22:16:50 +0200 Subject: [PATCH] fixing undescended caves thinggy --- core/forms.py | 8 ++------ parsers/caves.py | 5 +++++ templates/dataformat/cave.xml | 1 + templates/editcave.html | 11 +++++++++-- 4 files changed, 17 insertions(+), 8 deletions(-) diff --git a/core/forms.py b/core/forms.py index b798b3f53..67ffcfe4d 100644 --- a/core/forms.py +++ b/core/forms.py @@ -109,7 +109,7 @@ class CaveForm(ModelForm): exclude = ("filename", "url", "kataster_status") field_order = ['unofficial_number', 'kataster_number', 'official_name', 'unexplored', 'underground_description', 'survey', - 'underground_centre_line', 'explorers', 'equipment', 'notes', 'references', 'description_file', 'survex_file', + 'explorers', 'equipment', 'notes', 'references', 'description_file', 'survex_file', 'areacode', 'subarea', 'length', 'depth', 'extent', 'kataster_code', 'kataster_status', 'fully_explored', 'non_public', 'identified_login', 'who_are_you'] @@ -155,11 +155,7 @@ class EntranceForm(ModelForm): ) explorers = forms.CharField(required=False, widget=forms.TextInput(attrs={"size": "45"})) # explorers = forms.CharField(required = False, widget=TinyMCE(attrs={'cols': 80, 'rows': 10})) - # map_description = forms.CharField( - # label="Map (is this used?)", - # required=False, - # widget=HTMLarea(attrs={"height": "80%", "rows": 20, "placeholder": "Enter text (using HTML)"}), - # ) + location_description = forms.CharField( label="Location", required=False, diff --git a/parsers/caves.py b/parsers/caves.py index aeaedd822..ac9ca3249 100644 --- a/parsers/caves.py +++ b/parsers/caves.py @@ -197,6 +197,7 @@ def do_ARGE_cave(slug, caveid, areacode, svxid): cave = Cave( underground_description=commentary + line1 +line2 +line3 +passages +"", unofficial_number="", + unexplored=False, survex_file= f"{svxid}.svx", url=url, notes=default_note, @@ -412,6 +413,7 @@ def getXML(text, itemname, minItems=1, maxItems=None, context=""): def boolify(boolstrs): return { + "": False, "True": True, "False": False, "true": True, @@ -829,6 +831,8 @@ def read_cave(filename, mvf=None, cave=None): print(message) non_public = getXMLmax1("non_public") + unexplored = True + unexplored = getXMLmax1("unexplored") official_name = getXMLmax1("official_name") kataster_code = getXMLmax1("kataster_code") kataster_number = getXMLmax1("kataster_number") @@ -886,6 +890,7 @@ def read_cave(filename, mvf=None, cave=None): cave.areacode = areacode cave.non_public=boolify(non_public) + cave.unexplored=boolify(unexplored) cave.official_name=official_name[0] cave.kataster_code=kataster_code[0] if "+" in kataster_code[0]: diff --git a/templates/dataformat/cave.xml b/templates/dataformat/cave.xml index 5efd1b052..8fcb7e843 100644 --- a/templates/dataformat/cave.xml +++ b/templates/dataformat/cave.xml @@ -17,6 +17,7 @@ the form documented at {{ cave.non_public }} +{{ cave.unexplored }} {{ cave.official_name|default_if_none:""|safe }} {{cave.areacode |safe }} diff --git a/templates/editcave.html b/templates/editcave.html index 250391486..a7a3eda81 100644 --- a/templates/editcave.html +++ b/templates/editcave.html @@ -2,7 +2,10 @@ {% block title %} {% if cave.official_name or cave.kataster_number or cave.unofficial_number %} -Edit Cave - {{cave.official_name|safe}} - {{cave.kataster_number}} + Edit Cave - {{cave.official_name|safe}} - {{cave.kataster_number}} + {% if cave.unofficial_number %} + {{cave.unofficial_number|safe}} + {% endif %} {% else %} New Cave Creation Form {% endif %} @@ -13,7 +16,11 @@ New Cave Creation Form {% endblock %} {% block content %} {% if cave.official_name or cave.kataster_number or cave.unofficial_number %} -

Edit Cave - {{cave.official_name|safe}} {{cave.reference}}

+

Edit Cave - {{cave.official_name|safe}} {{cave.reference}} + {% if cave.unofficial_number %} + {{cave.unofficial_number|safe}} + {% endif %} +

The fields on this form, two of which are vital, are documented explicitly on the page cave entry fields and these same fields appear in the alternative file upload process as described in