2
0
mirror of https://expo.survex.com/repositories/troggle/.git synced 2024-11-23 07:41:52 +00:00

Implement add/edit/delete forms for logbook entries #1

Open
opened 2023-08-02 14:17:30 +01:00 by xle · 2 comments
Owner

Logbook entries are currently written by editing HTML inside an HTML form that contains all the logbook entries for the year. This HTML is then parsed using RegEx (apparently) and rendered into Django objects by a parser.

Code-efficiency wise, it would be best to set up class-based views as then we can re-use generic forms for add/edit/delete pages elsewhere, increasing maintainability. See https://ccbv.co.uk/ and https://docs.djangoproject.com/en/4.2/topics/class-based-views/.

Models-wise, we already define models.logbooks.LogbookEntry so adding templates and views for add/edit/delete should be trivial.

The logbook view template will need to be updated to provide hyperlinks for these actions.

Logbook entries are currently written by editing HTML inside an HTML form that contains *all* the logbook entries for the year. This HTML is then parsed using RegEx (apparently) and rendered into Django objects by a parser. Code-efficiency wise, it would be best to set up class-based views as then we can re-use generic forms for add/edit/delete pages elsewhere, increasing maintainability. See https://ccbv.co.uk/ and https://docs.djangoproject.com/en/4.2/topics/class-based-views/. Models-wise, we already define `models.logbooks.LogbookEntry` so adding templates and views for add/edit/delete should be trivial. The logbook view template will need to be updated to provide hyperlinks for these actions.
xle added the
Enhancement
label 2023-08-02 14:17:37 +01:00
xle added the
High Priority
label 2023-08-02 14:37:55 +01:00
Author
Owner

Added high priority label as this quality-of-life feature is actively dissuading non-nerds from contributing data to the set.

Added high priority label as this quality-of-life feature is actively dissuading non-nerds from contributing data to the set.
xle added the
Minor Change
label 2023-08-02 15:02:17 +01:00
xle added this to the Front-end Enhancements project 2023-08-02 15:23:09 +01:00
xle added this to the Expo 2024 milestone 2023-08-02 15:23:35 +01:00
Member
Progress. See https://expo.survex.com/logbookedit/2015_s43
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: expo/troggle#1
No description provided.