From dd0fcc28ddc4768fb8fa3edcec32ee205d77101b Mon Sep 17 00:00:00 2001 From: Philip Sargent Date: Wed, 27 Jul 2022 23:24:40 +0300 Subject: [PATCH] update todo strings --- core/forms.py | 2 +- parsers/caves.py | 13 +++---------- parsers/survex.py | 1 - 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/core/forms.py b/core/forms.py index f3df10a..9dd01db 100644 --- a/core/forms.py +++ b/core/forms.py @@ -18,7 +18,7 @@ There are other, simpler, upload forms in view/uploads.py Some are not used and need renovating or destroying. ''' -todo = '''Re-enable TinyMCE +todo = ''' ''' class CaveForm(ModelForm): diff --git a/parsers/caves.py b/parsers/caves.py index 3549c75..bc2bfbc 100644 --- a/parsers/caves.py +++ b/parsers/caves.py @@ -13,23 +13,16 @@ from troggle.core.models.caves import Area, Cave, Entrance, CaveSlug, EntranceSl '''Reads all the cave description data by parsing the xml files (stored as e.g. :EXPOWEB:/cave_data/1623-161.html ) and creating the various Cave, Entrance and necessary Area objects. -This is the first import that happens after the dabase is reinitialised. +This is the first import that happens after the database is reinitialised. So is the first thing that creates tables. -BUT in Django 2.0 and later we cannot do any queries on data we have just entered -because this is all happening inside one transaction. Bummer. - -django.db.transaction.TransactionManagementError: -An error occurred in the current transaction. You can't execute queries until the end of the 'atomic' block. ''' -todo='''- db Update does not work when a cave id is in the pending list but a proper cave description file exists - and is being imported. It should work. But currently Django aborts and he file is not read in. - +todo=''' - Cannot use Edit This Page for pendingcaves.txt_edit as Edit This Page is expecting an html file. So we will need a separate file-editing capability just for this configuration file ?! -- crashes on MariaDB on server when deleting Caves and complains Area needs a non null parent, But this is not true. +- crashes on MariaDB in databasereset.py on server when deleting Caves and complains Area needs a non null parent, But this is not true. The only solution we have found is to let it crash, then stop and restart MariaDB (requires a logon able to sudo) and then restart the databasereset.py again. (status as of July 2022) ''' diff --git a/parsers/survex.py b/parsers/survex.py index 7b94005..615019d 100644 --- a/parsers/survex.py +++ b/parsers/survex.py @@ -37,7 +37,6 @@ todo = '''Also walk the entire tree in the :loser: repo looking for unconnected - LoadSurvexFile() Creates a new current survexfile and valid .survexdirectory The survexblock passed-in is not necessarily the parent. FIX THIS. -- rx_qm recognises only simple survey point ids. EXTEND to cover more naming formats and test fully for 2023 ''' survexblockroot = None ROOTBLOCK = "rootblock"