expo/troggle
2
0
Fork 1
mirror of https://expo.survex.com/repositories/troggle/.git synced 2024-11-21 23:01:52 +00:00
Code Issues 19 Projects 3 Activity

to-do comments updated

Browse Source
This commit is contained in:
Philip Sargent 2024-07-15 12:41:58 +02:00
parent 11756fa0bb
commit 2cb665e141
3 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/models/caves.py
View File

@ -25,16 +25,7 @@ Gcave_count = None
""" """
todo = """ todo = """
- Find out why we have separate objects CaveSlug and why
these are not just a single field on the Model. This was Martin's idea,
but we are using text aliases now so we only need one slug in the data model
- Can we rewrite things to eliminate the CaveSlug and objects? Surely
foreign keys work fine ?!
- Why do we have CaveAndEntrance objects ? These do not need to be explcit for a many:many relationship these days - Why do we have CaveAndEntrance objects ? These do not need to be explcit for a many:many relationship these days
- move the aliases list from the code and put into an editable file
- Restore constraint: unique_together = (("area", "kataster_number"), ("area", "unofficial_number")) - Restore constraint: unique_together = (("area", "kataster_number"), ("area", "unofficial_number"))
or replace by a unique 'slug' field, better. or replace by a unique 'slug' field, better.

4
core/models/logbooks.py
View File

@ -15,10 +15,6 @@ from troggle.core.models.troggle import Expedition, TroggleModel
""" """
todo = """ todo = """
Foreign keys do not allow for there being multiple ways to refer to a cave, eg 1623-1999-03 aka 1623-204
Having slugs allows for much more loose coupling to caves, which removes alot of the need to reset the database, which interupts work flow.
It also means we do not have to be creating temporary cave objects in the database, where we do not have the underlying file in cave_data.
""" """

3
core/views/uploads.py
View File

@ -29,9 +29,6 @@ todo = """
Validate image files using a magic recogniser in walletedit() Validate image files using a magic recogniser in walletedit()
https://pypi.org/project/reportlab/ or https://pypi.org/project/reportlab/ or
https://stackoverflow.com/questions/889333/how-to-check-if-a-file-is-a-valid-image-file https://stackoverflow.com/questions/889333/how-to-check-if-a-file-is-a-valid-image-file
- Write equivalent GPX upload form system, similar to walletedit() but in expofiles/gpslogs/
Need to validate it as being a valid GPX file using an XML parser, not a dubious script or hack
- Validate Tunnel & Therion files using an XML parser in dwgupload(). Though Julian says - Validate Tunnel & Therion files using an XML parser in dwgupload(). Though Julian says
tunnel is only mostly correct XML, and it does fail at least one XML parser. tunnel is only mostly correct XML, and it does fail at least one XML parser.